feat: finish interceptors migration #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 13, 2024
dayaffe
approved these changes
Jul 18, 2024
milesziemer
force-pushed
the
finish-interceptor-migration
branch
from
92c3d98
to
222a24f
Compare
Removes all Middleware types, references, and implementations, completing migration to using Orchestrator + Interceptors. Tests using middleware were also migrated to use Orchestrator + Interceptors. Codegen was updated, removing the `useInterceptors` setting, switching all code that was either generating middleware or interceptors to just generate interceptors. This also allowed removing some other existing generator code around middleware steps. As with the corresponding aws-sdk-swift commit, this is already a large commit so I wanted to avoid doing too much refactoring or moving code around. For example, I didn't change file names or type names. There's probably a good deal of refactoring that can be done, but it is out of scope for this PR. Also, this commit removes the amz-sdk-invocation-id/amz-sdk-request header impl as it was moved to aws-sdk-swift in the corresponding commit.
milesziemer
force-pushed
the
finish-interceptor-migration
branch
from
222a24f
to
5529c8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
aws-sdk-swift pr: awslabs/aws-sdk-swift#1631
Removes all Middleware types, references, and implementations, completing migration to using Orchestrator + Interceptors. Tests using middleware were also migrated to use Orchestrator + Interceptors. Codegen was updated, removing the
useInterceptorssetting, switching all code that was either generating middleware or interceptors to just generate interceptors. This also allowed removing some other existing generator code around middleware steps.As with the corresponding aws-sdk-swift commit, this is already a large commit so I wanted to avoid doing too much refactoring or moving code around. For example, I didn't change file names or type names. There's probably a good deal of refactoring that can be done, but it is out of scope for this PR.
Also, this commit removes the amz-sdk-invocation-id/amz-sdk-request header impl as it was moved to aws-sdk-swift in the corresponding commit.
Scope
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.